Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow arbitrary clock referencing strategies #44

Merged
merged 2 commits into from
May 4, 2024
Merged

Conversation

glopesdev
Copy link
Member

To allow arbitrary referencing of the Harp data clock may require custom implementations to traverse the diverse object types which may represent a stream data attribute.

To allow for greater flexibility of implementations, e.g. in the case of EEG where we don't even control the reader class itself, this PR refactors the reference_harp_to_ubx_time method to use polymorphism, by introducing a new rereference_clock_origin in the base Stream class. This allows implementations to specify how exactly to apply a new arbitrary clock offset to the stream data.

@glopesdev glopesdev added the fix Pull request that fixes an issue label May 4, 2024
@glopesdev glopesdev requested a review from aspaNeuro May 4, 2024 21:46
@glopesdev glopesdev merged commit 50ddf89 into main May 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix Pull request that fixes an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant