Allow arbitrary clock referencing strategies #44
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow arbitrary referencing of the Harp data clock may require custom implementations to traverse the diverse object types which may represent a stream
data
attribute.To allow for greater flexibility of implementations, e.g. in the case of EEG where we don't even control the reader class itself, this PR refactors the
reference_harp_to_ubx_time
method to use polymorphism, by introducing a newrereference_clock_origin
in the baseStream
class. This allows implementations to specify how exactly to apply a new arbitrary clock offset to the stream data.