create-emotion-server: refactor inline for performance #725
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of renderStylesToString is highly inefficient as it allocates new arrays over and over, which isn't necessary. Instead just do a single pass hydrate which improves performance roughly 30x in most scenarios.
Codecov Report
|
Andarist
approved these changes
Jun 14, 2018
If I get some time, I'll definitely make a PR for those in the future. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current version of renderStylesToString is highly inefficient as it allocates new arrays over and over, which isn't necessary. Instead just do a single pass hydrate which improves performance roughly 30x in most scenarios.
We're using emotion at Postmates and this was a significant bottleneck to our SSR. (This change, which we're currently floating, took most of our style hydrates from 25-30ms to sub-1ms.)
I tested this by comparing the output of several pages and both the new and old produce identical markup. It doesn't seem like the tests in the library itself are quite detailed enough.
Checklist: