Add ClassInterpolation to typings #676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmatown
reviewed
May 26, 2018
| const StyledCompShorthandWithProps1 = createStyled.section<ShorthandProps>` | ||
| backgroundColor: ${props => getEditorLogoColor(props.editor)}; | ||
| const StyledCompShorthandWithProps1 = createStyled.section` | ||
| backgroundColor: ${(props: ShorthandProps) => getEditorLogoColor(props.editor)}; |
There was a problem hiding this comment.
What's the reason for this change?
There was a problem hiding this comment.
@mitchellhamilton Original one cannot pass checking in TS 2.3.
We should add yarn test:typescript to TravisCI...
There was a problem hiding this comment.
Yeah, I removed the ts tests from travis because it was crashing and I didn't have time to figure out why, if you want to fix it and add it back here that would be great.
There was a problem hiding this comment.
@mitchellhamilton I will add it after this one will be merged.
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Add ClassInterpolation to typings
Why: Original typings do not accept class interpolations, i.e.,
StyledComponentas interpolation.How: Add ClassInterpolation with private properties.
Checklist: