-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add typescript typings #37
Conversation
Codecov Report
@@ Coverage Diff @@
## master #37 +/- ##
=======================================
Coverage 87.54% 87.54%
=======================================
Files 15 15
Lines 530 530
Branches 107 107
=======================================
Hits 464 464
Misses 53 53
Partials 13 13
Continue to review full report at Codecov.
|
styled.d.ts
Outdated
declare module "emotion/styled" { | ||
import { Component } from "react"; | ||
|
||
export type Styler = ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This may need a name change. I plan on adding a Style
component in the future and this might get confusing. If this is how styled-components looks though then I say leave it.
I'm not really familiar with typescript so I'm going to have to rely on external reviewers on this. I trust you, @patrick91, and others can work together on this 👍 |
8750217
to
4db8d5d
Compare
@marvinhagemeister Hey can you update your pull with the latest version of emotion? |
I'm going to close this for #379 |
This PR adds typing so that the
styled
function will type-check when using typescript.Still marked as
wip
because somehow the template tags are not recognized yetFixes #40