Fix multiple nested selectors in media queries #324
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #324 +/- ##
==========================================
- Coverage 96.37% 96.32% -0.06%
==========================================
Files 16 16
Lines 580 571 -9
Branches 141 138 -3
==========================================
- Hits 559 550 -9
Misses 16 16
Partials 5 5
Continue to review full report at Codecov.
|
|
@mitchellhamilton You are correct, P1 should have said "black" not "blue". I can confirm that all issues have been fixed, both for the test cases and across my entire project. Amazing work, many thanks! LWJGL.org is now live in production with emotion@8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Fix multiple nested selectors in media queries
Why:
Closes #323
How:
The last argument to stylis plugins is an id which is 0 in context 2 if the style is not in a media query.
Checklist:
@apostolos I checked this with your test cases(Thanks so much!!!) and it works for all of them except
ExampleP1where the whole thing is black. From what I can see this is correct since there is nocolor: blueinExampleP1. If you disagree please reopen the issue.