Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow all imports to be configurable #306

Merged
merged 1 commit into from
Sep 14, 2017
Merged

Conversation

emmatown
Copy link
Member

What:

Allow all imports to be configurable.

This also replaces a .includes() with .indexOf() !== -1 for older node support.

Why:

So that all imports can be renamed instead of just styled and css.

How:

Don't filter them out and add them to defaultImportedNames.

Checklist:

  • Documentation N/A
  • Tests
  • Code complete

@codecov
Copy link

codecov bot commented Sep 14, 2017

Codecov Report

Merging #306 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
- Coverage   90.45%   90.43%   -0.02%     
==========================================
  Files          21       21              
  Lines         974      972       -2     
  Branches      261      260       -1     
==========================================
- Hits          881      879       -2     
  Misses         75       75              
  Partials       18       18
Impacted Files Coverage Δ
packages/babel-plugin-emotion/src/index.js 97.84% <100%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ac0a61...e2fe831. Read the comment docs.

@emmatown emmatown merged commit 1c95c3d into master Sep 14, 2017
@emmatown emmatown deleted the all-imports-configurable branch September 14, 2017 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant