-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fork Stylis prefixer #2890
Fork Stylis prefixer #2890
Conversation
🦋 Changeset detectedLatest commit: e7bffcb The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit e7bffcb:
|
Codecov Report
|
@Andarist to be clear, what issue is it? |
@siriwatknp this one: thysultan/stylis#301 . It got fixed in Stylis in September but I have only released an Emotion version with that fix just now |
I'm not super happy about this but we need to upgrade Stylis to leverage some a fix for incorrect CSS variable prefixing. At the same time, we already get some grief about the included prefixer that prefixes flexbox by default (and more). I think that prefixing the grid would only compound the problem and I don't think that we actually want to prefix those properties (and we can't selectively control what gets prefixed and what doesn't).
cc @siriwatknp, this would fix your issue