Export the EmotionCacheContext #2418
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: f25be59 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f25be59:
|
5 tasks
|
This sort-of got implemented in #2441 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Just exporting the EmotionCacheContext.
Why: So that Emotion users can more easily hook into it to build their own APIs without having to use
create-emotion. For example this issue could be resolved without an upstream change because theuseCxhook wouldn't need to rely on the internal_contextproperty on the Provider (which is undocumented).How: Just a two line change to export the cache context.
Checklist:
Alternatives to this are:
useEmotionCacheContextinstead of the context itselfNot sure if there are other alternatives other than adding
useCxupstream but I'm not sure if that's desired at this point. This is a stop-gap in case it's not viable to add directly into Emotion for whatever reason.