fix(): Pin libPhoneNumber-iOS dependendy to version 0.9.9 to fix iOS build error #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
azizsoule
changed the title
Nahrawene-ben-hmida
approved these changes
Aug 27, 2024
|
I would say that this repository is outdated. We should consider talking to the owner of the repository to transfer it to someone who can be more attentive to it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The underlying ios library (libPhoneNumber-iOS) used by this plugin has been updated yesterday from version 0.9.9 to 1.2.0 causing build error on iOS.
As a workaround to fix the plugin (version 2.0.2), I pin the dependency to version 0.9.9.
But the real fix should be to implement a newer version of the plugin using the latest version of libPhoneNumber-iOS (1.2.0) as it seems to contain breaking changes.
See libPhoneNumber-iOS cocoapods page