#263 observe deep sleep and keep sensors always available #264
Conversation
| @@ -182,6 +182,7 @@ | |||
| # Power units | |||
| POWER_WATT: Final = "W" | |||
| REACTIVE_POWER = "VAr" | |||
| POWER_FACTOR: Final = "Cos φ" | |||
There was a problem hiding this comment.
This seems unrelated to this PR?
| @@ -98,27 +104,65 @@ def __init__(self, **kwds: Any): | |||
| self._on_availability_callback: Callable[ | |||
| [bool], Coroutine[Any, Any, None] | |||
| ] | None = None | |||
| self.uses_deep_sleep = False | |||
| self.deep_sleep_interval = None | |||
| self.last_up=0 | |||
There was a problem hiding this comment.
Please give this a better name, maybe last_up_timestamp, timestamp_last_up or something like that
| super().__init__(**kwds) | ||
|
|
||
| def get_availability_topics(self) -> dict: | ||
| """Return MQTT topics to subscribe to for availability state.""" | ||
|
|
||
| async def availability_message_received(msg: ReceiveMessage) -> None: | ||
| """Handle a new received MQTT availability message.""" | ||
| last_up_retain=self.last_up |
| async def sleep_state_message_received(msg: ReceiveMessage) -> None: | ||
| """Handle state messages to indicate deep sleep.""" | ||
| #try: | ||
| # payload = json.loads(msg.payload) | ||
| #except json.decoder.JSONDecodeError: | ||
| # return | ||
| _LOGGER.debug("sleep state %s -> %s", msg.topic, msg.payload) | ||
| state = get_value_by_path(msg.payload, ["StatusPRM","RestartReason"]) | ||
| if state is not None: | ||
| state=str(state).lower() | ||
| if state.startswith('deep sleep'): | ||
| if not(self.uses_deep_sleep): | ||
| _LOGGER.debug("switching to deep sleep mode %s", msg.topic) | ||
| self.deep_sleep_interval=None | ||
| self.uses_deep_sleep=True |
There was a problem hiding this comment.
Instead of detecting a device's support for deep sleep when it wakes up from deep sleep, we should detect it from the device's discovery message: https://github.com/arendst/Tasmota/pull/19134/files#diff-fe970b21f48758677cb799d64f0ac866cbbe0aa48eb3e0f6aaa52c22ef73c735R189
Also
| if not(self.uses_deep_sleep): | ||
| available=False | ||
| else: | ||
| _LOGGER.debug("inhibit deep sleep %s", msg.topic) |
There was a problem hiding this comment.
Shouldn't we start a timer here, which if it expires sets availability to False and calls the availability callback?
You can use this timer class:
Lines 17 to 33 in 8a19e8d
|
@fra-orolo This is for sure wanted functionality, thanks for the PR! @stefanbode also started working on this functionality, he created this PR on tasmota: arendst/Tasmota#19134 If you want, you can contact me, @emontnemery, on discord to discuss the details. |
|
Yes, but we can see battery operated in telemetry and deepsleep. The on/off detection in hatasmoto has to be changed. This was more complicated than expected. |
This is a first part to keep deep-sleep sensors alive.
Seems to work for me, need to figure out timers...