Fix gatsbyjs#25207: Ensure assetPrefix, pathPrefix, and basePath are …

…correctly applied to URLs in manifest.webmanifest and HTML head. Also, address linting issues by correcting string literals and formatting.

.eslintrc.js

@@ -1,36 +1,271 @@
 module.exports = {
-  "env": {
-    "browser": true,
-    "es2021": true
-  },
-  "extends": [
-    "eslint:recommended",
-    "plugin:react/recommended",
-    "plugin:jsx-a11y/recommended",
-    "plugin:prettier/recommended",
-    "react-app"
+  parser: `@babel/eslint-parser`,
+  extends: [
+    `google`,
+    `eslint:recommended`,
+    `plugin:flowtype/recommended`,
+    `plugin:react/recommended`,
+    `prettier`,
   ],
-  "parserOptions": {
-    "ecmaFeatures": {
-      "jsx": true
+  plugins: [`flowtype`, `prettier`, `react`, `filenames`, `@babel`],
+  parserOptions: {
+    ecmaVersion: 2016,
+    sourceType: `module`,
+    ecmaFeatures: {
+      jsx: true,
+    },
+    babelOptions: {
+      configFile: `./.babelrc.js`,
     },
-    "ecmaVersion": 12,
-    "sourceType": "module"
   },
-  "plugins": [
-    "react",
-    "jsx-a11y",
-    "prettier"
+  env: {
+    browser: true,
+    es6: true,
+    node: true,
+    jest: true,
+  },
+  globals: {
+    before: true,
+    after: true,
+    spyOn: true,
+    // These should be in scope but for some reason eslint can't see them
+    NodeJS: true,
+    JSX: true,
+    NodeRequire: true,
+    TimerHandler: true,
+    __PATH_PREFIX__: true,
+    __BASE_PATH__: true,
+    __ASSET_PREFIX__: true,
+    _CFLAGS_: true,
+    __GATSBY: true,
+    __TRAILING_SLASH__: true,
+  },
+  rules: {
+    "@babel/no-unused-expressions": [
+      `error`,
+      {
+        allowTaggedTemplates: true,
+      },
+    ],
+    "no-unused-expressions": `off`,
+    "@babel/no-invalid-this": `error`,
+    "no-invalid-this": `off`,
+    "arrow-body-style": [
+      `error`,
+      `as-needed`,
+      { requireReturnForObjectLiteral: true },
+    ],
+    "new-cap": `off`,
+    "no-unused-vars": [
+      `warn`,
+      {
+        varsIgnorePattern: `^_`,
+        argsIgnorePattern: `^_`,
+        ignoreRestSiblings: true,
+      },
+    ],
+    "consistent-return": [`error`],
+    "filenames/match-regex": [`error`, `^[a-z-\\d\\.]+$`, true],
+    "no-console": `off`,
+    "no-inner-declarations": `off`,
+    "prettier/prettier": `error`,
+    quotes: [`error`, `backtick`],
+    "react/display-name": `off`,
+    "react/jsx-key": `warn`,
+    "react/no-unescaped-entities": `off`,
+    "react/prop-types": `off`,
+    "require-jsdoc": `off`,
+    "valid-jsdoc": `off`,
+    "prefer-promise-reject-errors": `warn`,
+    "no-prototype-builtins": `warn`,
+    "guard-for-in": `warn`,
+    "spaced-comment": [
+      `error`,
+      `always`,
+      { markers: [`/`], exceptions: [`*`, `+`] },
+    ],
+    camelcase: [
+      `error`,
+      {
+        properties: `never`,
+        ignoreDestructuring: true,
+        allow: [`^unstable_`],
+      },
+    ],
+  },
+  overrides: [
+    {
+      files: [
+        `packages/**/gatsby-browser.js`,
+        `packages/gatsby/cache-dir/**/*`,
+      ],
+      env: {
+        browser: true,
+      },
+      globals: {
+        ___loader: false,
+        ___emitter: false,
+      },
+    },
+    {
+      files: [`**/cypress/integration/**/*`, `**/cypress/support/**/*`],
+      globals: {
+        cy: false,
+        Cypress: false,
+      },
+    },
+    {
+      files: [`*.ts`, `*.tsx`],
+      parser: `@typescript-eslint/parser`,
+      plugins: [`@typescript-eslint/eslint-plugin`],
+      extends: [`plugin:@typescript-eslint/recommended`],
+      rules: {
+        // We should absolutely avoid using ts-ignore, but it's not always possible.
+        // particular when a dependencies types are incorrect.
+        "@typescript-eslint/ban-ts-comment": [
+          `warn`,
+          { "ts-ignore": `allow-with-description` },
+        ],
+        // This rule is great. It helps us not throw on types for areas that are
+        // easily inferrable. However we have a desire to have all function inputs
+        // and outputs declaratively typed. So this let's us ignore the parameters
+        // inferrable lint.
+        "@typescript-eslint/no-inferrable-types": [
+          `error`,
+          { ignoreParameters: true },
+        ],
+        "@typescript-eslint/ban-types": [
+          `error`,
+          {
+            extendDefaults: true,
+            types: {
+              "{}": {
+                fixWith: `Record<string, unknown>`,
+              },
+              object: {
+                fixWith: `Record<string, unknown>`,
+              },
+            },
+          },
+        ],
+        camelcase: `off`,
+        // TODO: These rules allow a lot of stuff and don't really enforce. If we want to apply our styleguide, we'd need to fix a lot of stuff
+        "@typescript-eslint/naming-convention": [
+          `error`,
+          {
+            selector: `default`,
+            format: [`camelCase`],
+          },
+          {
+            selector: `variable`,
+            format: [`camelCase`, `UPPER_CASE`, `PascalCase`],
+            leadingUnderscore: `allowSingleOrDouble`,
+            trailingUnderscore: `allowSingleOrDouble`,
+          },
+          {
+            selector: `function`,
+            format: [`camelCase`, `PascalCase`],
+            leadingUnderscore: `allow`,
+          },
+          {
+            selector: `parameter`,
+            format: [`camelCase`, `PascalCase`, `snake_case`],
+            leadingUnderscore: `allowSingleOrDouble`,
+          },
+          {
+            selector: `enumMember`,
+            format: [`camelCase`, `UPPER_CASE`, `PascalCase`],
+          },
+          {
+            selector: `typeLike`,
+            format: [`PascalCase`],
+          },
+          {
+            selector: `typeAlias`,
+            format: [`camelCase`, `PascalCase`],
+          },
+          {
+            selector: `property`,
+            format: null,
+          },
+          {
+            selector: `objectLiteralProperty`,
+            format: null,
+          },
+          {
+            selector: `enum`,
+            format: [`PascalCase`, `UPPER_CASE`],
+          },
+          {
+            selector: `method`,
+            format: [`PascalCase`, `camelCase`],
+            leadingUnderscore: `allowSingleOrDouble`,
+          },
+          {
+            selector: `interface`,
+            format: [`PascalCase`],
+            prefix: [`I`],
+          },
+        ],
+        // This rule tries to prevent using `require()`. However in node code,
+        // there are times where this makes sense. And it specifically is causing
+        // problems in our tests where we often want this functionality for module
+        // mocking. At this point it's easier to have it off and just encourage
+        // using top-level imports via code reviews.
+        "@typescript-eslint/no-var-requires": `off`,
+        "@typescript-eslint/no-extra-semi": `off`,
+        // This rule ensures that typescript types do not have semicolons
+        // at the end of their lines, since our prettier setup is to have no semicolons
+        // e.g.,
+        // interface Foo {
+        // -  baz: string;
+        // +  baz: string
+        // }
+        "@typescript-eslint/member-delimiter-style": [
+          `error`,
+          {
+            multiline: {
+              delimiter: `none`,
+            },
+          },
+        ],
+        "@typescript-eslint/no-empty-function": `off`,
+        // This ensures that we always type the return type of functions
+        // a high level focus of our TS setup is typing fn inputs and outputs.
+        "@typescript-eslint/explicit-function-return-type": `error`,
+        // This forces us to use interfaces over types aliases for object definitions.
+        // Type is still useful for opaque types
+        // e.g.,
+        // type UUID = string
+        "@typescript-eslint/consistent-type-definitions": [
+          `error`,
+          `interface`,
+        ],
+        "@typescript-eslint/no-use-before-define": [
+          `error`,
+          { functions: false },
+        ],
+        // Allows us to write unions like `type Foo = "baz" | "bar"`
+        // otherwise eslint will want to switch the strings to backticks,
+        // which then crashes the ts compiler
+        quotes: `off`,
+        "@typescript-eslint/quotes": [
+          2,
+          `backtick`,
+          {
+            avoidEscape: true,
+          },
+        ],
+        // bump to @typescript-eslint/parser started showing Flow related errors in ts(x) files
+        // so disabling them in .ts(x) files
+        "flowtype/no-types-missing-file-annotation": `off`,
+        "@typescript-eslint/array-type": [`error`, { default: `generic` }],
+      },
+    },
   ],
-  "rules": {
-    "prettier/prettier": "error",
-    "react/prop-types": "off",
-    "react/react-in-jsx-scope": "off"
+  settings: {
+    react: {
+      version: `18.2.0`,
+    },
   },
-  "globals": {
-    "__PATH_PREFIX__": true,
-    "__TRAILING_SLASH__": true,
-    "___emitter": true,
-    "GATSBY_LAYOUT_COMPONENT_PATH": true
-  }
-};
+}