-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added directory_layout() function #696
Conversation
It can suggest a directory layout from the IRIs of all the imported ontologies.
WIP: Fix issues with changed IRIs effecting test_excelparser
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #696 +/- ##
==========================================
+ Coverage 71.02% 71.49% +0.46%
==========================================
Files 16 16
Lines 3369 3385 +16
==========================================
+ Hits 2393 2420 +27
+ Misses 976 965 -11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, but please describe system for how the layout is generated.
ontopy/utils.py
Outdated
Returns: | ||
layout: A dict mapping ontology objects to relative path names with | ||
with the file extension stripped off. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PLease explain the heurestics more in detail. This is documentation so that people understand what to expect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Har lagt til et eksempel i docstring.
Description
It can suggest a directory layout from the IRIs of all the imported ontologies.
The generation of catalog files has been updated and some bugs in write_catalog() has been fixed. Including:
The read_catalog() has gotten a new argument
relative_to
which is needed when asking for relative paths. Using this argument ensures that the catalog test is now not dependent on the current working directory when invoking the test.Type of change
Checklist
This checklist can be used as a help for the reviewer.
Comments