-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HermiT is default reasoner. #671
Conversation
Ontoconvert used to accept only FaCT++ because owlready2.reasoning._apply_reasoning_results() was broken. It added the inferred rdfs:subClassOf relations as rdf:type relations.
Codecov Report
@@ Coverage Diff @@
## master #671 +/- ##
==========================================
+ Coverage 69.85% 70.09% +0.23%
==========================================
Files 16 16
Lines 3367 3367
==========================================
+ Hits 2352 2360 +8
+ Misses 1015 1007 -8
|
Created dummy tests for all three reasoners. Need to fill in with what we want to test for.
…toPy into allow_hermit_ontoconvert
tests/ontopy_tests/test_reasoner.py
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Possible improvement of this test:
Does testonto contain enough semantics for the reasoners to work with, such that they can add additional relations?
If not, one could consider to add an object property to testonto with a domain and range to give the reasoner something to work with.
If/when the reasoners add something, that should be tested for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
Ontoconvert used to accept only FaCT++ because
owlready2.reasoning._apply_reasoning_results() was broken. It added the inferred
rdfs:subClassOf relations as rdf:type relations.
Description
Type of change
Checklist
This checklist can be used as a help for the reviewer.
Comments