-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added two additional exceptions to emmocheck #577
Conversation
Codecov Report
@@ Coverage Diff @@
## master #577 +/- ##
==========================================
+ Coverage 67.25% 67.28% +0.03%
==========================================
Files 16 16
Lines 3127 3127
==========================================
+ Hits 2103 2104 +1
+ Misses 1024 1023 -1
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not think the correct way to go about exceptions to emmocheck for ontologies except emmo itself is to add disregarded labels in emmocheck at top level. Then one should be able to add a list of labels to disregard in emmocheck.
I fully agree. But these concepts are in EMMO. |
Correction. 3DPrinting is not in EMMO any more - so I have removed the exception for that. |
Description:
Added the following two exceptions to emmocheck
Type of change:
Checklist:
This checklist can be used as a help for the reviewer.
Comments: