Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not trigger an emmocheck failure for ontologies with a foaf:logo annotation #509

Merged
merged 6 commits into from
Dec 13, 2022

Conversation

jesper-friis
Copy link
Collaborator

CHAMIO (and EMMO with PR 212) includes a foaf:logo annotation.
This PR makes sure that this does not trigger a missing prefLabel error.

Note that the "automatic" prefix assigned by OwlReady2 for foaf is rather awkward. It becomes "0.1" since that is the last component of the foaf IRI: http://xmlns.com/foaf/0.1/.

Description:

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

requirements_dev.txt Outdated Show resolved Hide resolved
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PRs should be made as a response to an issue, which is then closed with the PR.

Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason the action has stoppd and is not in the queue , but this should be fine to merge now.

@jesper-friis jesper-friis merged commit 96930bf into master Dec 13, 2022
@jesper-friis jesper-friis deleted the allow-foaf-logo branch December 13, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants