-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makeover for CI/CD workflows, pre-commit & MkDocs #485
Conversation
Use more from SINTEF/ci-cd and also determine code coverage and upload it to codecov.io. Upload different coverages for each package.
These tasks are replaced by SINTEF/ci-cd workflows and pre-commit hooks.
Fixed the EMMC logo and link (from emmc.info to emmc.eu). Fixed indentation in release instructions. Fixed plugin settings for MkDocs.
Extend copyright to 2022.
This is a draft until #486 has been resolved. |
Play around with the sys.path additions for tools.
Co-authored-by: Francesca L. Bleken <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #485 +/- ##
=========================================
Coverage ? 62.91%
=========================================
Files ? 16
Lines ? 3055
Branches ? 0
=========================================
Hits ? 1922
Misses ? 1133
Partials ? 0 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you suggestion of removing official support of python 3.6 is good. We have not been testing for that version until now. Alternatively, we have to rename the excel-file to .xls. I think that should work, but it is getting quite outdated.
Extend testing with Python 3.8-3.10. Add explicit support for Python3.8-3.10 in setup.py (package) metadata.
I have removed Python 3.6 support, while extending official support to include Python 3.8, 3.9, and 3.10 (by adding these versions specifically to the metadata in |
@jesper-friis I'd like some input /review from you on this PR as well, especially regarding the supported Python version changes this will introduce (see #486 for reference). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. I am however, a little hesitant about it being much less transparent now. I suggest we open an issue about documenting a bit more.
Information on the finalization of this PR:
|
That's completely fair. But we should definitely extend the EMMOntoPy documentation for developers to include references to this other documentation. |
I agree with this suggestion. |
If we could improve the documentation of SINTEF/ci-cd, I think delegating to those tools is only beneficially and makes the ci/cd much easier to read. See e.g. cache for a typical example of documentation a github action. |
It's important to understand that the SINTEF/ci-cd repository does not provide actions, but rather callable workflows. I.e., complete workflows with their own step-logic and actions usage. I think the documentation is quite extensive as is, but everything can always be improved. Please visit the documentation here and evaluate for yourself. |
I think this looks quite OK already. Only thing is to add the documentation (link to this repo) for ontopy developers as you mention. |
Description:
Fixes #481
Fixes #482
Closes #486
CI/CD
This PR implements a complete makeover for the CI/CD workflows, utilizing the SINTEF/ci-cd callable GitHub Actions workflows as well as the pre-commit hooks there.
Benefits of this makeover:
invoke
dependency andtasks.py
file, since theseinvoke
tasks are replaced by the hooks and workflows from SINTEF/ci-cd.Possible drawbacks:
invoke
tasks for pre-commit hooks can lead to less flexibility if changes are needed and not implemented in the external workflows/hooks.Overall, I think this is a huge improvement and should ease CI/CD immensely.
Documentation
Some updates in the MkDocs configuration were necessary to fix some presentation issues of certain documentation pages.
The table of contents (ToC) has been improved to exclude the
emmodoc
markdown template files under the "Examples" section.The EMMC-CSA reference on the landing page has been updated to point to emmc.eu instead of the old emmc.info web page. Furthermore, the logo reference has been fixed to point to a local PNG image.
Type of change:
Checklist:
This checklist can be used as a help for the reviewer.
Comments: