Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed reading web destinations defined in catalog #445

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

francescalb
Copy link
Collaborator

@francescalb francescalb commented Aug 19, 2022

Updated reading from catalog so that full urls to webprotocols when
given as destination are used directly.

Description:

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update.

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

@francescalb francescalb linked an issue Aug 19, 2022 that may be closed by this pull request
@francescalb francescalb merged commit 02b3c84 into master Aug 19, 2022
@francescalb francescalb deleted the issue369-catalog-file branch August 19, 2022 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Avoid infinite recursion when loading catalog file
2 participants