Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use width in img HTML #235

Merged
merged 1 commit into from
Sep 28, 2021
Merged

Use width in img HTML #235

merged 1 commit into from
Sep 28, 2021

Conversation

CasperWA
Copy link
Contributor

@CasperWA CasperWA commented Sep 28, 2021

Description:

Update in README.md and used inv create-docs-index to update the index.md in the documentation.

Fixes #233.

Type of change:

  • Bug fix.
  • New feature.
  • Documentation update. (kind of)

Checklist:

This checklist can be used as a help for the reviewer.

  • Is the code easy to read and understand?
  • Are comments for humans to read, not computers to disregard?
  • Does a new feature has an accompanying new test (in the CI or unit testing schemes)?
  • Has the documentation been updated as necessary?
  • Does this close the issue?
  • Is the change limited to the issue?
  • Are errors handled for all outcomes?
  • Does the new feature provide new restrictions on dependencies, and if so is this documented?

Comments:

In order to test this locally do the following:

$ git fetch origin && git branch cwa/fix-233-doc-images origin/cwa/fix-233-doc-images && git checkout cwa/fix-233-doc-images
$ pip install -U -e .[docs]
$ mkdocs serve

Then go to: http://127.0.0.1:8000/EMMO-python and scroll down to see that the images are nicely sized now.

Update in README.md and used `inv create-docs-index` to update the
index.md in the documentation.
@CasperWA CasperWA added the documentation Improvements or additions to documentation label Sep 28, 2021
Copy link
Collaborator

@francescalb francescalb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good, looks nice now :) (Should we try to have index.md and README.md reading info about contributing projects from one common place?)

@CasperWA
Copy link
Contributor Author

Very good, looks nice now :) (Should we try to have index.md and README.md reading info about contributing projects from one common place?)

What do you mean exactly by this?

As it is now:
README.md is the "source" and index.md is "generated" using the invoke task create-docs-index.
This task essentially copies the README.md file, renames it, and fixes the relative links in the file.
index.md is only used in the documentation, while README.md is only used/presented on GitHub - and serves as the local README file as well, of course :)

So the "one common place" (even though it doesn't seem like it) is indeed the README.md file.

But if you mean that we can have a dedicated documentation page about the contributing projects, then, yes! That's a great idea :)

@francescalb
Copy link
Collaborator

Very good, looks nice now :) (Should we try to have index.md and README.md reading info about contributing projects from one common place?)

What do you mean exactly by this?

As it is now: README.md is the "source" and index.md is "generated" using the invoke task create-docs-index. This task essentially copies the README.md file, renames it, and fixes the relative links in the file. index.md is only used in the documentation, while README.md is only used/presented on GitHub - and serves as the local README file as well, of course :)

So the "one common place" (even though it doesn't seem like it) is indeed the README.md file.

But if you mean that we can have a dedicated documentation page about the contributing projects, then, yes! That's a great idea :)

Ah, I see. I just looked at the 'Files changed' here and saw that both were changed. I did not realise that the index.md is generated from the README.md.

@CasperWA
Copy link
Contributor Author

Ah, I see. I just looked at the 'Files changed' here and saw that both were changed. I did not realise that the index.md is generated from the README.md.

Yeah, no worries.
The actual auto-generation will be implemented as part of #232.

@CasperWA CasperWA merged commit 6e284f4 into master Sep 28, 2021
@CasperWA CasperWA deleted the cwa/fix-233-doc-images branch September 28, 2021 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix images in documentation
2 participants