Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidy up unittests #220

Closed
CasperWA opened this issue Sep 21, 2021 · 0 comments · Fixed by #239
Closed

Tidy up unittests #220

CasperWA opened this issue Sep 21, 2021 · 0 comments · Fixed by #239
Assignees
Labels
python Pull requests that update Python code testing Issue/PR related to code testing

Comments

@CasperWA
Copy link
Contributor

PR #208 moved to proper pytest functions for the tests, however, it didn't tidy up the tests.

The tests should be revisited and considered whether they can be optimized.

Most importantly, the tests shouldn't produce a lot of "garbage" files; all files should be temporary if at all.
For examples one can/should add these to the examples/ folder or demo/.

@CasperWA CasperWA added python Pull requests that update Python code testing Issue/PR related to code testing labels Sep 21, 2021
@CasperWA CasperWA self-assigned this Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code testing Issue/PR related to code testing
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant