-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update package names #208
Update package names #208
Conversation
They are installable under the EMMOntoPy name.
Have absolute imports everywhere except `__init__.py` files.
Update version retrieval by pointing it to `ontopy` instead of `emmopy`.
e526b58
to
6e838f5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good and did not find any glaring things to fix. I have one question though: since we decided to use ontopy this could come in conflict with the python package ontopy if someone would want to use that at the same time. Is this an issue we should care about?
This is an excellent (a difficult to answer) question. We can extrapolate that noone is using the old However, it doesn't, of course, change the fact that the project could be taken up again at any time and be reused.
|
This still cannot be updated for GitHub links and the Dockerfile. While the first is obvious (the repository still has not been renamed), the latter is less so. The main reason here is that the Docker instructions outline how one installs the package in within the Docker container. And the `setup.py` file instructs to find data files in the shared folder `EMMO-python`.
I agree, conflict with the older ontopy from 2009 is not a problem. We should consider reaching out to get the ontopy anyways, to make sure that noone else does it and makes a conflicting new ontopy. Bur for now I think we are good. |
Another issue is the documentation. Now it says pip install EMMO in the readme, but should be pip install EMMOntoPy. And there should be a small section about the name change in the README. |
Yes and no, I guess. It's the same "chicken'n'egg" problem as changing all occurrences of For the installable |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am convinced. Looks nice :)
Update package names according to discussion in #205. Closes #205.
Note, this is a draft PR and only here to have CI running and an easy way of getting to the working branch.Important: This PR now also updates the
pytest
testing, removing the unittest runner file and instead encapsulating all the test files in appropriate functions, which is the normal way to runpytest
tests.If this is an issue due to some developer not running the tests via
pytest
locally, or the unittest runner class in thetest_runner.py
file did extra checks and tests that are currently not included, this can either be extracted out of this PR or I can try to re-add it in apytest
-friendly way.As a note, this update/edit of the test files is not a rewrite, and the tests should be properly ported to the
pytest
test-writing architecture in another PR (creating fixtures, etc. as needed).