Clean up most mypy warnings #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
November 9, 2018 13:58
* release/0.50.0: removed debug true from tests fixed v1 test and extended v0 tests deleted old test file code review changes wip: saving work improved auth tests and bumped envoy to the latest sha fixed the missing comma in the static whitelist added support for request and authorization whitelist headers initial ext_authz commit # Conflicts: # ambassador/ambassador/ir/irauth.py # ambassador/tests/kat/test_ambassador.py
* release/0.50.0: added docs and rolled back v0 config logic # Conflicts: # ambassador/ambassador/envoy/v2/v2listener.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tackles most of the
mypy(and pycharm) warnings about Ambassador.What's left:
multi? gotta fix that)post_error, but those will get resolved as I clean up the sad path through Ambassador in general.