Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part 1 of taking a chainsaw to a bunch of stuff we don't need. There's more to come.
NOTE: you'll need to have a
v4.0.0-test.0
tag to do much with these changes, but please don't push such a tag yet.There are three commits in this PR. I strongly recommend reading the review notes below.
This is a monster commit. DON'T try to review it in the GitHub UI; there are some 1200 deleted files, since this commit deletes the
_cxx
,api/envoy
, andpkg/envoy-control-plane
directories completely: we simply don't need these if we're no longer building our own Envoy. Of course, that means that we need to change a bunch of Go imports to use the stock Envoy packages rather than the ones we compile.To see just the changes in this commit, the easiest way is probably
We also don't need to screw around with the
base-python
,base-pip
, andbase-envoy
Docker images at all.base-envoy
goes away because we're not building our own Envoy;base-python
andbase-pip
go away because using distroless rather than Alpine simplifies the world enough that the complexity of these two images isn't worth it: I can do a full rebuild in about five minutes on my laptop.This commit is OK to review in GitHub, it's only a dozen files or so.
Finally, this commit switches to using goreleaser to build other Docker images. I think this gets the ones we need to actually run tests, but maybe I'm wrong.
Once this commit lands, then
goreleaser release
should build multiarch images for everything.