Ensure make clean always removes build artifacts #4988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keeping with the current system, adds additional clean targets as necessary to ensure a make images / make clean cycle always functions properly. Signed-off-by: Rick Lane <[email protected]>
haq204
approved these changes
Apr 23, 2023
tenshinhigashi
approved these changes
Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Keeping with the current system, adds additional clean targets as necessary to ensure a make images / make clean cycle always functions properly.
Description
Adds additional
cleantargets to match existingclobbertargets. Personally, I'd prefer a split between having thecleantargets only clean up the internal artifacts, and havingclobberalso remove the images from the registry. But that change would need to be applied systemically/separately, and it's somewhat opinionated.Related Issues
#4986
Testing
Local build testing.
Checklist
CHANGELOG.md.DEVELOPING.mdwith any any special dev tricks I had to use to work on this code efficiently.