Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CC] Resolve Service port names in Ingress #4813

Merged
merged 9 commits into from
Feb 3, 2023

Conversation

haq204
Copy link

@haq204 haq204 commented Jan 23, 2023

Description

Brings in #4809

Related Issues

#4322

Testing

CC PR adds unit tests

Checklist

  • Does my change need to be backported to a previous release?

    • What backport versions were discussed with the Maintainers in the Issue?
  • I made sure to update CHANGELOG.md.

    Remember, the CHANGELOG needs to mention:

    • Any new features
    • Any changes to our included version of Envoy
    • Any non-backward-compatible changes
    • Any deprecations
  • This is unlikely to impact how Ambassador performs at scale.

    Remember, things that might have an impact at scale include:

    • Any significant changes in memory use that might require adjusting the memory limits
    • Any significant changes in CPU use that might require adjusting the CPU limits
    • Anything that might change how many replicas users should use
    • Changes that impact data-plane latency/scalability
  • My change is adequately tested.

    Remember when considering testing:

    • Your change needs to be specifically covered by tests.
      • Tests need to cover all the states where your change is relevant: for example, if you add a behavior that can be enabled or disabled, you'll need tests that cover the enabled case and tests that cover the disabled case. It's not sufficient just to test with the behavior enabled.
    • You also need to make sure that the entire area being changed has adequate test coverage.
      • If existing tests don't actually cover the entire area being changed, add tests.
      • This applies even for aspects of the area that you're not changing – check the test coverage, and improve it if needed!
    • We should lean on the bulk of code being covered by unit tests, but...
    • ... an end-to-end test should cover the integration points
  • I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.

  • The changes in this PR have been reviewed for security concerns and adherence to security best practices.

@haq204 haq204 force-pushed the hqudsi/ingress-with-named-ports branch from fa795b5 to 6aa6a0c Compare January 24, 2023 21:58
@haq204 haq204 marked this pull request as ready for review January 24, 2023 22:40
Anton Ustyuzhanin and others added 9 commits February 3, 2023 10:15
…ency's discovered_services dict

Signed-off-by: Anton Ustyuzhanin <[email protected]>
Signed-off-by: Anton Ustyuzhanin <[email protected]>
Signed-off-by: Anton Ustyuzhanin <[email protected]>
Signed-off-by: Anton Ustyuzhanin <[email protected]>
Signed-off-by: Anton Ustyuzhanin <[email protected]>
Signed-off-by: Anton Ustyuzhanin <[email protected]>
Signed-off-by: Anton Ustyuzhanin <[email protected]>
Signed-off-by: Hamzah Qudsi <[email protected]>
@haq204 haq204 force-pushed the hqudsi/ingress-with-named-ports branch from 0445dfa to e6f207b Compare February 3, 2023 15:34
@haq204 haq204 merged commit 7a6edf7 into master Feb 3, 2023
@haq204 haq204 deleted the hqudsi/ingress-with-named-ports branch February 3, 2023 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants