Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.x Python dep updates #4503

Merged
merged 4 commits into from
Sep 14, 2022
Merged

v2.x Python dep updates #4503

merged 4 commits into from
Sep 14, 2022

Conversation

ddymko
Copy link
Member

@ddymko ddymko commented Sep 13, 2022

Description

Cherry-picked the following two commits to update some of the python Libs that have been updated in v3.

Related Issues

List related issues.

Testing

CI goes green

Checklist

  • I made sure to update CHANGELOG.md.

    Remember, the CHANGELOG needs to mention:

    • Any new features
    • Any changes to our included version of Envoy
    • Any non-backward-compatible changes
    • Any deprecations
  • This is unlikely to impact how Ambassador performs at scale.

    Remember, things that might have an impact at scale include:

    • Any significant changes in memory use that might require adjusting the memory limits
    • Any significant changes in CPU use that might require adjusting the CPU limits
    • Anything that might change how many replicas users should use
    • Changes that impact data-plane latency/scalability
  • My change is adequately tested.

    Remember when considering testing:

    • Your change needs to be specifically covered by tests.
      • Tests need to cover all the states where your change is relevant: for example, if you add a behavior that can be enabled or disabled, you'll need tests that cover the enabled case and tests that cover the disabled case. It's not sufficient just to test with the behavior enabled.
    • You also need to make sure that the entire area being changed has adequate test coverage.
      • If existing tests don't actually cover the entire area being changed, add tests.
      • This applies even for aspects of the area that you're not changing – check the test coverage, and improve it if needed!
    • We should lean on the bulk of code being covered by unit tests, but...
    • ... an end-to-end test should cover the integration points
  • I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.

  • The changes in this PR have been reviewed for security concerns and adherence to security best practices.

Lance Austin and others added 4 commits September 13, 2022 08:06
Although this exist in other places it has a lot of dependencies
and is hard to figure out what command to run. This adds a
simple target that only needs to be run once when developing
against the python components of emissary-ingress.

It provides a simple developer QOL improvement.

Signed-off-by: Lance Austin <[email protected]>
Updates to the latest flask version to address cve warnings and ensures
we are on the latest release for our deps. It also updated a few of the
indirect dependencies for flask

Signed-off-by: Lance Austin <[email protected]>
Signed-off-by: David Dymko <[email protected]>
Signed-off-by: David Dymko <[email protected]>
@ddymko ddymko marked this pull request as ready for review September 13, 2022 15:27
@ddymko ddymko added the dependencies Pull requests that update a dependency file label Sep 13, 2022
Makefile Show resolved Hide resolved
Makefile Show resolved Hide resolved
@ddymko ddymko merged commit 72574f6 into release/v2.4 Sep 14, 2022
@ddymko ddymko deleted the python-dep-updates branch September 14, 2022 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants