.github: Fix the repatriation logic to deal with merged/closed PRs #4242
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If there's an old PR that's already been merged, that means we should be creating a new one, rather than assuming that pushing to the branch will update the old one.
As seen on https://github.com/emissary-ingress/emissary/runs/6523998225
Testing
I used
gh
on the CLI to try out these commands interactively. But I noticed some minor differences ingh pr view
than what we see in CI, so apparently versions are different; so who knows if this will actually work in CI?Checklist
I made sure to update
CHANGELOG.md
. - no applicable changesRemember, the CHANGELOG needs to mention:
This is unlikely to impact how Ambassador performs at scale.
Remember, things that might have an impact at scale include:
My change is adequately tested.
Remember when considering testing:
I updated
DEVELOPING.md
with any any special dev tricks I had to use to work on this code efficiently. - no tricksThe changes in this PR have been reviewed for security concerns and adherence to security best practices.