Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI for #4179 #4192

Closed
wants to merge 3 commits into from
Closed

CI for #4179 #4192

wants to merge 3 commits into from

Conversation

d6e-automaton
Copy link
Collaborator

The Lightstep tracer supports multiple propagation modes.
See https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/trace/v3/lightstep.proto#enum-config-trace-v3-lightstepconfig-propagationmode

With this PR it is now possible to set a list of propagation modes in
the config field of the TracingService.

Signed-off-by: Paul Salaberria [email protected]

  • I made sure to update CHANGELOG.md.
  • This is unlikely to impact how Ambassador performs at scale.
  • My change is adequately tested.
  • No need to update DEVELOPING.md.

psalaberria002 and others added 3 commits April 5, 2022 21:13
The Lightstep tracer supports multiple propagation modes.
See https://www.envoyproxy.io/docs/envoy/latest/api-v3/config/trace/v3/lightstep.proto#enum-config-trace-v3-lightstepconfig-propagationmode

With this PR it is now possible to set a list of propagation modes in
the config field of the TracingService.

Signed-off-by: Paul Salaberria <[email protected]>
… into psalaberria002-propagationmodes

Signed-off-by: Flynn <[email protected]>
@kflynn
Copy link
Member

kflynn commented Apr 22, 2022

Excellent! I'll go land #4179 now that we have a good CI run here. Thanks, @psalaberria002!

@kflynn kflynn closed this Apr 22, 2022
@kflynn kflynn deleted the psalaberria002-propagationmodes branch April 22, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants