-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v1.14.2] Release Branch #3822
Merged
Merged
[v1.14.2] Release Branch #3822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: w-h37 <[email protected]>
kflynn
previously approved these changes
Sep 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hit it!
Signed-off-by: w-h37 <[email protected]>
Signed-off-by: AliceProxy <[email protected]>
Signed-off-by: AliceProxy <[email protected]>
aidanhahn
previously approved these changes
Sep 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Send it!
Signed-off-by: w-h37 <[email protected]>
…ngelog-updates Willhardin/v1.14.2/changelog updates
kflynn
approved these changes
Sep 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hit it!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All commits that are going out in 1.14.2 release must be on rel/v1.14.2.
This will allow the appropriate CI to run.
To get the hotfix changes onto this branch you can do one of the following:
* use rel/v1.14.2 as the development branch for the fix
* land (or have already landed) hotfix changes on release/v1.14 branch, and merge release/v1.14 into rel/v1.14.2
* cherry-pick hotfix commits from ambassador.git to rel/v1.14.2
It is okay if you've already landed the hotfix changes on release/v1.14 branch,
reviewers just need to validate that the hotfix commits are in the tree for rel/v1.14.2,
and all the appropriate changelog updates exist.
REVIEWERS MUST CHECK THAT: