Configure DNS refresh rate from DNS record TTL #3807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: AliceProxy [email protected]
Description
Creates a new field in
Mappings
calledrespect_dns_ttl
this configures Envoy’s DNS refresh rate for the Mapping. When true, the cluster’s DNS refresh rate will be set to resource record’s TTL which comes from DNS resolution.Relevant Envoy Config
Related Issues
List related issues.
Testing
A few sentences describing what testing you've done, e.g., manual tests, automated tests, deployed in production, etc.
Checklist
I made sure to update
CHANGELOG.md
.Remember, the CHANGELOG needs to mention:
This is unlikely to impact how Ambassador performs at scale.
Remember, things that might have an impact at scale include:
My change is adequately tested.
Remember when considering testing:
to run legacy-mode tests manually (set
AMBASSADOR_LEGACY_MODE=true
and run the tests).(This will be fixed soon.)
I updated
DEVELOPING.md
with any any special dev tricks I had to use to work on this code efficiently.