Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release promotion: Have images know their own released version #3802

Merged
merged 5 commits into from
Sep 17, 2021

Conversation

LukeShu
Copy link
Contributor

@LukeShu LukeShu commented Sep 17, 2021

Description

The main objective of this PR is to have it so that when we promote an image we also add a layer letting it know what its new version number is.

But I also slipped in 2 other things:

  • Consolidate the tools that the build system uses in to tools.mk and ./tools/src/.
  • Shut up the CI failures from CircleCI and CodeQL

Related Issues

#3854

Testing

A few sentences describing what testing you've done, e.g., manual tests, automated tests, deployed in production, etc.

Checklist

  • I made sure to update CHANGELOG.md. - yep

    Remember, the CHANGELOG needs to mention:

    • Any new features
    • Any changes to our included version of Envoy
    • Any non-backward-compatible changes
    • Any deprecations
  • This is unlikely to impact how Ambassador performs at scale.

    Remember, things that might have an impact at scale include:

    • Any significant changes in memory use that might require adjusting the memory limits
    • Any significant changes in CPU use that might require adjusting the CPU limits
    • Anything that might change how many replicas users should use
    • Changes that impact data-plane latency/scalability
  • [-] My change is adequately tested. - kinda, I did the best I could to test this manually without actually doing a release.

    Remember when considering testing:

    • LEGACY MODE TESTS DO NOT RUN FOR EVERY PR. If your change is affected by legacy mode, you need
      to run legacy-mode tests manually (set AMBASSADOR_LEGACY_MODE=true and run the tests).
      (This will be fixed soon.)
    • Your change needs to be specifically covered by tests.
      • Tests need to cover all the states where your change is relevant: for example, if you add a behavior that can be enabled or disabled, you'll need tests that cover the enabled case and tests that cover the disabled case. It's not sufficient just to test with the behavior enabled.
    • You also need to make sure that the entire area being changed has adequate test coverage.
      • If existing tests don't actually cover the entire area being changed, add tests.
      • This applies even for aspects of the area that you're not changing – check the test coverage, and improve it if needed!
    • We should lean on the bulk of code being covered by unit tests, but...
    • ... an end-to-end test should cover the integration points
  • I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently. - no tricks

@LukeShu LukeShu force-pushed the lukeshu/promote2 branch 2 times, most recently from 01657e8 to 2291ff7 Compare September 17, 2021 06:25
@LukeShu LukeShu force-pushed the lukeshu/promote2 branch 2 times, most recently from 3de1257 to 8e46e9c Compare September 17, 2021 07:39
@LukeShu LukeShu changed the title Lukeshu/promote2 release promotion: Have images know their own released version Sep 17, 2021
@LukeShu LukeShu marked this pull request as ready for review September 17, 2021 07:55
Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good (albeit with a couple commits that look scary at first glance 😂 ). Thanks!

@LukeShu LukeShu merged commit d4931e0 into master Sep 17, 2021
@LukeShu LukeShu deleted the lukeshu/promote2 branch September 17, 2021 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants