Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix tweaks #3659

Merged
merged 9 commits into from
Aug 3, 2021
Merged

Hotfix tweaks #3659

merged 9 commits into from
Aug 3, 2021

Conversation

kflynn
Copy link
Member

@kflynn kflynn commented Aug 2, 2021

Best reviewed commit-by-commit. This is all cleanup of details for the 1.x hotfix process (and, soon, the 2.x
hotfix process too).

  • Clean up indentation.
  • Consistent ;\
  • Fix missing `
  • Use $$( ) instead of `` (it's slightly easier to catch a missing close-paren than a missing backtick).
  • Missing semicolon
  • Drop excess ;
  • Allow overriding the hotfix commitish using HOTFIX_COMMIT. Fix a couple of other small things (e.g. an excess \ in the regex).
  • Fix push tag.
  • Fix AWS secret key assignment.

Flynn added 9 commits August 2, 2021 16:44
Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
…e-paren than a missing backtick).

Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
…le of other small things (e.g. an excess `\` in the regex).

Signed-off-by: Flynn <[email protected]>
Signed-off-by: Flynn <[email protected]>
@kflynn kflynn requested a review from a team August 2, 2021 21:58
@kflynn kflynn merged commit 456b3b2 into release/v1.13 Aug 3, 2021
@kflynn kflynn deleted the flynn/dev/hotfix-tweaks branch August 3, 2021 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants