Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cors origins roundtrip fix #3612

Merged
merged 3 commits into from
Jul 16, 2021
Merged

cors origins roundtrip fix #3612

merged 3 commits into from
Jul 16, 2021

Conversation

acookin
Copy link
Contributor

@acookin acookin commented Jul 15, 2021

Description

A few sentences describing the overall goals of the pull request's commits.

Related Issues

List related issues.

Testing

A few sentences describing what testing you've done, e.g., manual tests, automated tests, deployed in production, etc.

Checklist

  • I made sure to update CHANGELOG.md.

    Remember, the CHANGELOG needs to mention:

    • Any new features
    • Any changes to our included version of Envoy
    • Any non-backward-compatible changes
    • Any deprecations
  • This is unlikely to impact how Ambassador performs at scale.

    Remember, things that might have an impact at scale include:

    • Any significant changes in memory use that might require adjusting the memory limits
    • Any significant changes in CPU use that might require adjusting the CPU limits
    • Anything that might change how many replicas users should use
    • Changes that impact data-plane latency/scalability
  • My change is adequately tested.

    Remember when considering testing:

    • LEGACY MODE TESTS DO NOT RUN FOR EVERY PR. If your change is affected by legacy mode, you need
      to run legacy-mode tests manually (set AMBASSADOR_LEGACY_MODE=true and run the tests).
      (This will be fixed soon.)
    • Your change needs to be specifically covered by tests.
      • Tests need to cover all the states where your change is relevant: for example, if you add a behavior that can be enabled or disabled, you'll need tests that cover the enabled case and tests that cover the disabled case. It's not sufficient just to test with the behavior enabled.
    • You also need to make sure that the entire area being changed has adequate test coverage.
      • If existing tests don't actually cover the entire area being changed, add tests.
      • This applies even for aspects of the area that you're not changing – check the test coverage, and improve it if needed!
    • We should lean on the bulk of code being covered by unit tests, but...
    • ... an end-to-end test should cover the integration points
  • I updated DEVELOPING.md with any any special dev tricks I had to use to work on this code efficiently.

@acookin acookin changed the base branch from master to rel/v1.13.10 July 15, 2021 21:33
@acookin acookin force-pushed the acookin/cors-mapping-fix branch from a9265d5 to a77daa8 Compare July 15, 2021 21:34
acookin added 3 commits July 15, 2021 17:36
Signed-off-by: Alix Cook <[email protected]>
Signed-off-by: Alix Cook <[email protected]>
Signed-off-by: Alix Cook <[email protected]>
@acookin acookin force-pushed the acookin/cors-mapping-fix branch from e6b9c99 to 5ded324 Compare July 15, 2021 21:37
@acookin acookin linked an issue Jul 15, 2021 that may be closed by this pull request
Copy link
Member

@kflynn kflynn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@acookin acookin merged commit 87b58cc into rel/v1.13.10 Jul 16, 2021
@acookin acookin deleted the acookin/cors-mapping-fix branch July 16, 2021 20:24
aidanhahn pushed a commit that referenced this pull request Jul 26, 2021
* cors mapping fix

Signed-off-by: Alix Cook <[email protected]>

* fake test

Signed-off-by: Alix Cook <[email protected]>

* changelog

Signed-off-by: Alix Cook <[email protected]>
LukeShu pushed a commit that referenced this pull request Sep 30, 2021
* cors mapping fix

Signed-off-by: Alix Cook <[email protected]>

* fake test

Signed-off-by: Alix Cook <[email protected]>

* changelog

Signed-off-by: Alix Cook <[email protected]>

Signed-off-by: Luke Shumaker <[email protected]>
kflynn pushed a commit that referenced this pull request Oct 4, 2021
* cors mapping fix

Signed-off-by: Alix Cook <[email protected]>

* fake test

Signed-off-by: Alix Cook <[email protected]>

* changelog

Signed-off-by: Alix Cook <[email protected]>

Signed-off-by: Luke Shumaker <[email protected]>
LukeShu pushed a commit that referenced this pull request Oct 5, 2021
* cors mapping fix

Signed-off-by: Alix Cook <[email protected]>

* fake test

Signed-off-by: Alix Cook <[email protected]>

* changelog

Signed-off-by: Alix Cook <[email protected]>

Signed-off-by: Luke Shumaker <[email protected]>
LukeShu pushed a commit that referenced this pull request Oct 5, 2021
* cors mapping fix

Signed-off-by: Alix Cook <[email protected]>

* fake test

Signed-off-by: Alix Cook <[email protected]>

* changelog

Signed-off-by: Alix Cook <[email protected]>

Signed-off-by: Luke Shumaker <[email protected]>
kflynn pushed a commit that referenced this pull request Oct 6, 2021
* cors mapping fix

Signed-off-by: Alix Cook <[email protected]>

* fake test

Signed-off-by: Alix Cook <[email protected]>

* changelog

Signed-off-by: Alix Cook <[email protected]>

Signed-off-by: Luke Shumaker <[email protected]>
kflynn pushed a commit that referenced this pull request Oct 6, 2021
* cors mapping fix

Signed-off-by: Alix Cook <[email protected]>

* fake test

Signed-off-by: Alix Cook <[email protected]>

* changelog

Signed-off-by: Alix Cook <[email protected]>

Signed-off-by: Luke Shumaker <[email protected]>
kflynn pushed a commit that referenced this pull request Oct 7, 2021
* cors mapping fix

Signed-off-by: Alix Cook <[email protected]>

* fake test

Signed-off-by: Alix Cook <[email protected]>

* changelog

Signed-off-by: Alix Cook <[email protected]>

Signed-off-by: Luke Shumaker <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Cors Origin Comma Separated Lists Don't Work
2 participants