-
Notifications
You must be signed in to change notification settings - Fork 687
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cors origins roundtrip fix #3612
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acookin
force-pushed
the
acookin/cors-mapping-fix
branch
from
July 15, 2021 21:34
a9265d5
to
a77daa8
Compare
Signed-off-by: Alix Cook <[email protected]>
Signed-off-by: Alix Cook <[email protected]>
Signed-off-by: Alix Cook <[email protected]>
acookin
force-pushed
the
acookin/cors-mapping-fix
branch
from
July 15, 2021 21:37
e6b9c99
to
5ded324
Compare
kflynn
approved these changes
Jul 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks!
aidanhahn
pushed a commit
that referenced
this pull request
Jul 26, 2021
* cors mapping fix Signed-off-by: Alix Cook <[email protected]> * fake test Signed-off-by: Alix Cook <[email protected]> * changelog Signed-off-by: Alix Cook <[email protected]>
LukeShu
pushed a commit
that referenced
this pull request
Sep 30, 2021
* cors mapping fix Signed-off-by: Alix Cook <[email protected]> * fake test Signed-off-by: Alix Cook <[email protected]> * changelog Signed-off-by: Alix Cook <[email protected]> Signed-off-by: Luke Shumaker <[email protected]>
kflynn
pushed a commit
that referenced
this pull request
Oct 4, 2021
* cors mapping fix Signed-off-by: Alix Cook <[email protected]> * fake test Signed-off-by: Alix Cook <[email protected]> * changelog Signed-off-by: Alix Cook <[email protected]> Signed-off-by: Luke Shumaker <[email protected]>
LukeShu
pushed a commit
that referenced
this pull request
Oct 5, 2021
* cors mapping fix Signed-off-by: Alix Cook <[email protected]> * fake test Signed-off-by: Alix Cook <[email protected]> * changelog Signed-off-by: Alix Cook <[email protected]> Signed-off-by: Luke Shumaker <[email protected]>
LukeShu
pushed a commit
that referenced
this pull request
Oct 5, 2021
* cors mapping fix Signed-off-by: Alix Cook <[email protected]> * fake test Signed-off-by: Alix Cook <[email protected]> * changelog Signed-off-by: Alix Cook <[email protected]> Signed-off-by: Luke Shumaker <[email protected]>
kflynn
pushed a commit
that referenced
this pull request
Oct 6, 2021
* cors mapping fix Signed-off-by: Alix Cook <[email protected]> * fake test Signed-off-by: Alix Cook <[email protected]> * changelog Signed-off-by: Alix Cook <[email protected]> Signed-off-by: Luke Shumaker <[email protected]>
kflynn
pushed a commit
that referenced
this pull request
Oct 6, 2021
* cors mapping fix Signed-off-by: Alix Cook <[email protected]> * fake test Signed-off-by: Alix Cook <[email protected]> * changelog Signed-off-by: Alix Cook <[email protected]> Signed-off-by: Luke Shumaker <[email protected]>
4 tasks
kflynn
pushed a commit
that referenced
this pull request
Oct 7, 2021
* cors mapping fix Signed-off-by: Alix Cook <[email protected]> * fake test Signed-off-by: Alix Cook <[email protected]> * changelog Signed-off-by: Alix Cook <[email protected]> Signed-off-by: Luke Shumaker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A few sentences describing the overall goals of the pull request's commits.
Related Issues
List related issues.
Testing
A few sentences describing what testing you've done, e.g., manual tests, automated tests, deployed in production, etc.
Checklist
I made sure to update
CHANGELOG.md
.Remember, the CHANGELOG needs to mention:
This is unlikely to impact how Ambassador performs at scale.
Remember, things that might have an impact at scale include:
My change is adequately tested.
Remember when considering testing:
to run legacy-mode tests manually (set
AMBASSADOR_LEGACY_MODE=true
and run the tests).(This will be fixed soon.)
I updated
DEVELOPING.md
with any any special dev tricks I had to use to work on this code efficiently.