Switch to the Envoy proxy_protocol filter instead of using use_proxy_proto. #2358
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are three things going on this commit, but all of them need to be in one commit for things to work.
use_proxy_proto
is no longer aVHost
thing.a. This is why you see all the deletion of stuff in
V2VirtualHost
aboutuse_proxy_proto
.b. This is also why you see
use_proxy_proto
vanishing from all the calls instantiating aV2VirtualHost
.use_proxy_proto
is instead now aV2Listener
thing.a. This is OK because, at present,
use_proxy_proto
is a system-wide configuration. Later, it needs to be part of the per-listener config.b. This is why you see
use_proxy_proto
getting added toV2Listener
.V2ListenerCollection
gains aget
method, becausea. using
__getitem__
really didn't make sense, it was a design choice back when I thought more needed to be in theV2ListenerCollection
classb. we really need to pass
use_proxy_proto
in on creation, and__getitem__
relying on two inputs would be even more absurd than it used to be.Fixes #2348.
Documentation doesn't need to change. Testing was with
KAT
and usingcurl --haproxy
to test the TLS termination + PROXY protocol case.Tasks That Must Be Done