mapping: automatically include the l5d-dst-override header #1643
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
June 21, 2019 09:09
Signed-off-by: Gabriel Linden Sagula <[email protected]>
Signed-off-by: Gabriel Linden Sagula <[email protected]>
Signed-off-by: Gabriel Linden Sagula <[email protected]>
Signed-off-by: Gabriel Linden Sagula <[email protected]>
Signed-off-by: Gabriel Linden Sagula <[email protected]>
Signed-off-by: Gabriel Linden Sagula <[email protected]>
Signed-off-by: Gabriel Linden Sagula <[email protected]>
Signed-off-by: Gabriel Linden Sagula <[email protected]>
Signed-off-by: Gabriel Linden Sagula <[email protected]>
kflynn
requested changes
Jun 27, 2019
added 5 commits
June 27, 2019 05:51
Signed-off-by: Gabriel Linden Sagula <[email protected]>
Signed-off-by: Gabriel Linden Sagula <[email protected]>
Signed-off-by: Gabriel Linden Sagula <[email protected]>
…dor module Signed-off-by: Gabriel Linden Sagula <[email protected]>
Signed-off-by: Gabriel Linden Sagula <[email protected]>
|
@kflynn Thanks for the review. Please feel free to take another look. |
added 2 commits
June 27, 2019 11:18
Signed-off-by: Gabriel Linden Sagula <[email protected]>
Signed-off-by: Gabriel Linden Sagula <[email protected]>
kflynn
requested changes
Jun 28, 2019
Signed-off-by: Gabriel Linden Sagula <[email protected]>
Signed-off-by: Gabriel Linden Sagula <[email protected]>
Signed-off-by: Gabriel Linden Sagula <[email protected]>
Signed-off-by: Gabriel Linden Sagula <[email protected]>
kflynn
reviewed
Jul 3, 2019
| else: | ||
| add_linkerd_headers = module.get('add_linkerd_headers', None) | ||
| if add_linkerd_headers is None: | ||
| self["add_linkerd_headers"] = ir.ambassador_module.get('add_linkerd_headers', False) |
There was a problem hiding this comment.
This logic, I think, is wrong if add_linkerd_headers is explicitly set to False in the AuthService when it's set to True in the ambassador Module. The logic below for IRHTTPMapping looks correct.
| else: | ||
| if 'add_linkerd_headers' in ir.ambassador_module and ir.ambassador_module.add_linkerd_headers is True: | ||
| add_request_hdrs['l5d-dst-override'] = svc.hostname_port | ||
|
|
There was a problem hiding this comment.
I think this is the logic that should be used in both Mapping and AuthService.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for automatically include the l5d-dst-override header to all requests, including authorization (when configured).
Related Issues
#1594
#1578
Testing
KAT - mapping and auth tests