Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix diag-report issue with resolvers #1621

Merged
merged 2 commits into from
Jun 13, 2019
Merged

Fix diag-report issue with resolvers #1621

merged 2 commits into from
Jun 13, 2019

Conversation

kflynn
Copy link
Member

@kflynn kflynn commented Jun 12, 2019

Whoops. When we include an IRGroup in the resolver report, we need to call as_dict on it.

Also, give the CLI a way to specify the directory to which to save secrets, so that it can more effectively work with snapshots that have secrets in them.

@kflynn kflynn merged commit ca02234 into master Jun 13, 2019
@kflynn kflynn deleted the flynn/dev/resolver-diag branch June 13, 2019 03:28
alexgervais pushed a commit that referenced this pull request Jul 21, 2020
Adjust QuickStart page at upright monitor width to enable Nav bar usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant