Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don’t require the port when a user maps a resource; it’s not needed. #16

Merged
merged 1 commit into from
Apr 7, 2017
Merged

Don’t require the port when a user maps a resource; it’s not needed. #16

merged 1 commit into from
Apr 7, 2017

Conversation

kflynn
Copy link
Member

@kflynn kflynn commented Apr 7, 2017

Fixes #15.

@kflynn kflynn merged commit a5549c2 into master Apr 7, 2017
@kflynn kflynn deleted the flynn/defect/port-not-needed branch April 7, 2017 19:36
@vaibhavrtk vaibhavrtk mentioned this pull request Feb 13, 2019
Closed
LukeShu pushed a commit that referenced this pull request Sep 6, 2019
@rhs
Merge pull request #16 from datawire/e2e_test_stage
9bc8278 
tests: tests for e2e CI stage
LukeShu added a commit that referenced this pull request Sep 6, 2019
@LukeShu
Merge pull request #16 from datawire/lukeshu/docker.mk
3166034 
Use docker.mk, move release logic in to Makefile

This has the side-effect that apictl is now pushed to S3 on every PR (just like the images are pushed to Quay on every PR).
LukeShu added a commit that referenced this pull request Sep 6, 2019
@LukeShu
Merge pull request #16 from datawire/lukeshu/makefile-improvements
31de4a5 
Makefile improvements

This should address some concerns from @plombardi89.

 - When version.mk detects that we're dirty in CI (which it correctly
   triggers an error for), have the error message tell you *what* is
   dirty, instead of just telling you that *something* is dirty, and
   hoping that you can correctly guess what it is.
 - Have Makefile automatically detect `./docker/*/Dockerfile` builds,
   instead of having to manually list them in the Makefile.
 - Have `make help` tell you what the VERSION is.
 - Go ahead and cross-compile to always build for *both* macOS and
   GNU/Linux.  Since @plombardi89 noted that he got "This should not
   happen in CI: the build should not be dirty.  Stop." on the
   macos-build but not machine-build, hopefully this will make the
   error case visible on his GNU/Linux workstation.
LukeShu added a commit that referenced this pull request Sep 6, 2019
@LukeShu
Squashed 'build-aux/' changes from fd5752c..1fd8c4c
c1a57b9 
1fd8c4c (apro) Merge commit '4081fbffa92537dcdf0cf8aaf679a82fb0ded84d'
e2a82a0 (apro) docker.mk: Be a little more robust
a1f95c3 (apro) teleproxy.mk: Integrate more closely with kubernaut-ui.mk
3e0d1c7 (apro) docker.mk: Also tag :latest when building an image
9f28b56 (apro) teleproxy.mk: Don't restart the proxy unnecessarily
48e111f (apro) docker.mk: Clean up old image versions
06135dc (apro) docker.mk: Be a little more robust in port-forward cleanup
9944fda (apro) Merge pull request #16 from datawire/lukeshu/makefile-improvements
2931de0 (apro) _go-common.mk: Add the go.PLATFORMS setting
a3d00d8 (apro) help.mk: Define a default `help.body` that lists the NAME and VERSION
2e6922a (apro) version.mk: Be more helpful in your error message

git-subtree-dir: build-aux
git-subtree-split: 1fd8c4c
LukeShu pushed a commit that referenced this pull request Sep 9, 2019
@kflynn
Merge pull request #16 from datawire/lukeshu/no-xds
79d0ba5 
Use github.com/datawire/ambassador/go/apis/ instead of ./xds/
rhs added a commit that referenced this pull request Oct 9, 2019
@rhs
Merge pull request #16 from datawire/rhs/multi-process
1d261fc 
Rhs/multi process
rhs pushed a commit that referenced this pull request Oct 9, 2019
@LukeShu
Squashed 'build-aux/' changes from fd5752c..f81abe9
1c17abe 
f81abe9 (apro) Merge commit 'cf16af317a7b91ed38a990aab5eab4119cab9608' into lukeshu/lint-v0
016600a (apro) _go-common.mk: Merge "check-go-fmt" and "go-vet" in to "go-lint" And use golangci-lint to do it.
986c494 README.md: fix instructions for converting to Go modules
35bb9fc (apro) docker.mk: Have .knaut-push store the correct name on macOS
1fd8c4c (apro) Merge commit '4081fbffa92537dcdf0cf8aaf679a82fb0ded84d'
e2a82a0 (apro) docker.mk: Be a little more robust
a1f95c3 (apro) teleproxy.mk: Integrate more closely with kubernaut-ui.mk
3e0d1c7 (apro) docker.mk: Also tag :latest when building an image
9f28b56 (apro) teleproxy.mk: Don't restart the proxy unnecessarily
48e111f (apro) docker.mk: Clean up old image versions
06135dc (apro) docker.mk: Be a little more robust in port-forward cleanup
9944fda (apro) Merge pull request #16 from datawire/lukeshu/makefile-improvements
2931de0 (apro) _go-common.mk: Add the go.PLATFORMS setting
a3d00d8 (apro) help.mk: Define a default `help.body` that lists the NAME and VERSION
2e6922a (apro) version.mk: Be more helpful in your error message

git-subtree-dir: build-aux
git-subtree-split: f81abe9
LukeShu added a commit that referenced this pull request Aug 1, 2020
@LukeShu
(apro) Merge pull request #16 from datawire/lukeshu/makefile-improvem…
9944fda 
…ents

Makefile improvements

This should address some concerns from @plombardi89.

 - When version.mk detects that we're dirty in CI (which it correctly
   triggers an error for), have the error message tell you *what* is
   dirty, instead of just telling you that *something* is dirty, and
   hoping that you can correctly guess what it is.
 - Have Makefile automatically detect `./docker/*/Dockerfile` builds,
   instead of having to manually list them in the Makefile.
 - Have `make help` tell you what the VERSION is.
 - Go ahead and cross-compile to always build for *both* macOS and
   GNU/Linux.  Since @plombardi89 noted that he got "This should not
   happen in CI: the build should not be dirty.  Stop." on the
   macos-build but not machine-build, hopefully this will make the
   error case visible on his GNU/Linux workstation.
LukeShu added a commit that referenced this pull request Aug 1, 2020
@LukeShu
Merge pull request #16 from datawire/lukeshu/ci
a8db462 
Fix CI
acookin pushed a commit that referenced this pull request Mar 10, 2021
@iNoahNothing
Add option to set restartPolicy
ad09d9f 
Resolves: #16

Signed-off-by: Noah Krause <[email protected]>
acookin added a commit that referenced this pull request Aug 18, 2021
@acookin
gotest fix (#16)
ddcbc5d 
* gotest fix

* undo
acookin added a commit that referenced this pull request Aug 24, 2021
@acookin
gotest fix (#16)
8e48b43 
* gotest fix

* undo

Signed-off-by: Flynn <[email protected]>
acookin added a commit that referenced this pull request Aug 24, 2021
@acookin @aidanhahn
@Alice-Lilith @kflynn
[v2.0.2-ea] Release Branch (#3701)
b23ceab 
* ensure pod log uploading when pytests fail

- incorrect if() clause in yaml caused failure to upload pod logs,
  making it hard to diagnose failures

Signed-off-by: Alice Nodelman <[email protected]>

* fixup links in readme (#3682)

Signed-off-by: Alix Cook <[email protected]>

* fix chart readme (#3690)

Signed-off-by: Alix Cook <[email protected]>

* Document similar implementation in DevPortal (#3691)

* Document similar implementation in DevPortal

Signed-off-by: alex <[email protected]>

* Added comment to the AmbassadorMapping CRD docs attribute

Signed-off-by: alex <[email protected]>

* make generate

Signed-off-by: Alix Cook <[email protected]>

Co-authored-by: Alix Cook <[email protected]>

* split out t_mappingtests into namespace sets (default and plain)

    - some of the mappingtests are designed to run in the default namespace,
      some in the plain namespace.  Split up these tests into different py
      files to make it easier to understand and execute
    - update pytest harness to start an httpbin for each namespace
      defined in tests under execution
    - update plain test gold file to use correct namespace

Signed-off-by: Alice Nodelman <[email protected]>

* add devel (#3696)

Signed-off-by: Alix Cook <[email protected]>

* Update for v2.0.2-ea (#3698)

Signed-off-by: Alix Cook <[email protected]>

* Update for v2.0.2-ea

Signed-off-by: Alix Cook <[email protected]>

* update envoy commit

Signed-off-by: Aidan Hahn <[email protected]>

* dont push manifests if IS_PRIVATE

Signed-off-by: Flynn <[email protected]>

* updates for embargoed

Signed-off-by: Flynn <[email protected]>

* envoy v3 should be default

Signed-off-by: Flynn <[email protected]>

* run make generate

Signed-off-by: Flynn <[email protected]>

* Update for v1.14.0.

* dont push manifests if IS_PRIVATE
* updates for embargoed
* Update for v1.14.0

Signed-off-by: Alix Cook <[email protected]>

* fixup changelog

Signed-off-by: Flynn <[email protected]>

* gotest fix (#16)

* gotest fix

* undo

Signed-off-by: Flynn <[email protected]>

* remove tests that were commented out on master

Signed-off-by: Aidan Hahn <[email protected]>
Signed-off-by: Flynn <[email protected]>

* enable deprecated apis

Signed-off-by: Flynn <[email protected]>

* pytest corrections (#18)

Signed-off-by: Aidan Hahn <[email protected]>
Signed-off-by: Flynn <[email protected]>

* gzip fix (#19)

* gzip fix

* update ambex

* update ambex

* update circle

Signed-off-by: Flynn <[email protected]>

* pytest envoy v2 test fixes (#21)

Signed-off-by: Flynn <[email protected]>

* envoy v2 fixes maybz (#22)

* envoy v2 fixes maybz

* envoy v2 fixes maybz

Signed-off-by: Flynn <[email protected]>

* also push rc for emissary privaet

Signed-off-by: Flynn <[email protected]>

* allow chunked length (#24)

* expose chunked length

Signed-off-by: AliceProxy <[email protected]>

improve test coverage

Signed-off-by: AliceProxy <[email protected]>

Remove v2listener and v2Test

Signed-off-by: AliceProxy <[email protected]>

add setting to protos

Signed-off-by: AliceProxy <[email protected]>

make generate

Signed-off-by: AliceProxy <[email protected]>

* comment out test

* test fixes

* UNDO THIS

* mkay

* comment out test

Co-authored-by: AliceProxy <[email protected]>
Signed-off-by: Flynn <[email protected]>

* update pf gomod

Signed-off-by: Flynn <[email protected]>

* extauth needs "ignore_case" for auth and request headers

Signed-off-by: Aidan Hahn <[email protected]>
Signed-off-by: Flynn <[email protected]>

* yank deprecated config option

Signed-off-by: Aidan Hahn <[email protected]>
Signed-off-by: Flynn <[email protected]>

* update t_chunked_length test

Signed-off-by: Aidan Hahn <[email protected]>
Signed-off-by: Flynn <[email protected]>

* Log ambex snapshots

Signed-off-by: Flynn <[email protected]>

* ambex logging cleanup

Signed-off-by: Flynn <[email protected]>

* Update goldfiles for V3 #1 (from d15d3b4)

Signed-off-by: Flynn <[email protected]>

* fix fake_mapping_cors_test

Signed-off-by: Flynn <[email protected]>

* fix chunked length

Signed-off-by: Flynn <[email protected]>

* fix envoy_api_version

Signed-off-by: Flynn <[email protected]>

* make go-mod-tidy

Signed-off-by: Flynn <[email protected]>

* Update t_chunked_length for V2

Signed-off-by: Flynn <[email protected]>

* Update gold files

Signed-off-by: Flynn <[email protected]>

* CHANGELOG

Signed-off-by: Flynn <[email protected]>

* make generate

Signed-off-by: Flynn <[email protected]>

* Temporary fix for repo name.

Signed-off-by: Flynn <[email protected]>

* remove fake mapping test, make generate

Signed-off-by: Flynn <[email protected]>

* bump envoy in 2.0.2

* fix manifest stuff

* fix is private thing again

Co-authored-by: Alice Nodelman <[email protected]>
Co-authored-by: Alex Gervais <[email protected]>
Co-authored-by: Aidan Hahn <[email protected]>
Co-authored-by: Flynn <[email protected]>
Co-authored-by: Aidan Hahn <[email protected]>
Co-authored-by: AliceProxy <[email protected]>
Co-authored-by: Flynn <[email protected]>
LukeShu pushed a commit that referenced this pull request Sep 30, 2021
@acookin @LukeShu
gotest fix (#16)
56a1110 
* gotest fix

* undo
Signed-off-by: Luke Shumaker <[email protected]>

Signed-off-by: Alix Cook <[email protected]>
kflynn pushed a commit that referenced this pull request Oct 4, 2021
@acookin
gotest fix (#16)
a5a64c2 
* gotest fix

* undo
Signed-off-by: Luke Shumaker <[email protected]>

Signed-off-by: Alix Cook <[email protected]>
@kflynn kflynn mentioned this pull request Oct 4, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kflynn