Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow TLS context in AuthService #1229

Merged
merged 2 commits into from
Feb 15, 2019
Merged

Allow TLS context in AuthService #1229

merged 2 commits into from
Feb 15, 2019

Conversation

kflynn
Copy link
Member

@kflynn kflynn commented Feb 15, 2019

Fixes #1202. Note that issue #1224 is still a factor -- you cannot mix HTTP and HTTPS upstreams for anything right now, including AuthService. This should be fixed soon.

@kflynn
Copy link
Member Author

kflynn commented Feb 15, 2019

(Also note that the substantive change here is adding tls back to AuthService.schema -- the code to process it was already present, the only problem was that the schema wouldn't allow setting it.)

@kflynn kflynn merged commit f4bad40 into master Feb 15, 2019
@kflynn kflynn deleted the flynn/dev/1202 branch February 15, 2019 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AuthService no longer recognized tls options
1 participant
@kflynn