Fix secret handling #1153
Merged
Fix secret handling #1153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
January 27, 2019 00:53
…stable. Don't re-parse the config for every diag page load.
* master: Update ambassador-with-aws.md Updated AWS documentation with more configuration examples Update simple rate limiting example for v1 api update for 0.1.2 final set of fixes? fix formatting bug fixes and formatting fixes fix license key location clean up whitespace, remove mapping doc change remove bypass_auth from mappings doc; add assertions to test call out bypass_auth in docs add test for bypassing auth add mapping attribute for disabling auth
…an update from kubewatch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than persisting all secrets to disk, we don't ask about secrets we haven't been told to use.
Additionally:
All of this happens by letting the long-lived (and now quite misnamed)
diagdprocess own the Ambassador configuration, so that it can be more discriminatory in what it requests fromkubewatch, and cache the configuration between changes.This will fix #1093 and #1118. A future PR will finish the job of removing the old
kubewatch.py(it's now only used in a vestigial startup role).