Clean up some annoyances #1107
Merged
Clean up some annoyances #1107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 11, 2019 12:55
* release/0.50.0: V1 TLSContext hosts is _not_ a required property. This should've been changed ages ago. fixed issue with empty body request methods switched back to the non-production image Fix broken link Change docs landing page
…ne will override a get-with-defaults. Use an or instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #1071 by correctly managing upstream contexts when SNI is active (
context.get('hosts', [])will not return an empty array ifcontext.hostsis explicitly set toNone), and clean up a bunch of mypy warnings around TLS contexts.