fixed issue with wesocket handshake and authz filter #1091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gabriel <[email protected]>
gsagula
force-pushed
the
websocket_fix
branch
from
2bb0f08 to
ec5eb9c
Compare
Signed-off-by: Gabriel <[email protected]>
|
@kflynn Feel free to take a look. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR updates Ambassador with a new Envoy image that fixes #1026. The issue was in Authorization filter with
send request datawas enabled. The previous implementation relied on the headers end of stream signal to start the asynchronous authorization request. However whensending request datawas enabled and end of the stream was true, the authorization call was supposed to be invoked during data decoding which, in the case of a WebSocket handshake for example, never happens. The issue was fixed by inspecting the request before initiating the authorization call, which could happen during header decoding or data decoding, depending on the request method and thesend request dataconfiguration.Signed-off-by: Gabriel [email protected]