Automatically include default auth headers with a V0 config #1079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 3, 2019 11:47
… not necessary to explicitly list Location or Set-Cookie. Update test to use new requested-location header so that we can test that V0 really does automagically include Location.
…d-ProtoX-Gateway-Proto instead of X-Forwarded-Proto and X-Gateway-Proto.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.50.0 has a set of default headers that are always allowed to go from an external auth service to the upstream service:
Authorization,Location,Proxy-Authenticate,Set-Cookie, andWWW-Authenticate. These were always included when configuring anAuthServiceusing API versionambassador/v1; this PR also includes them for API versionambassador/v0.A separate typo was glomming
X-Forwarded-ProtoandX-Gateway-Protointo one header, so we were not allowing either header, but were instead allowingX-Forwarded-ProtoX-Gateway-Proto. That's fixed here too, but I'm not going to hold this for a test for that.Fixes #1054. May fix #1053.