Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

grpc-web filter addition for envoy template #1076

Closed
wants to merge 1 commit into from
Closed

grpc-web filter addition for envoy template #1076

wants to merge 1 commit into from

Conversation

jtdawso
Copy link

@jtdawso jtdawso commented Jan 2, 2019

@saeid-ir
Copy link

saeid-ir commented Jan 20, 2019 •
edited
Loading

No one to solve these conflicts?

@kflynn
Copy link
Member

kflynn commented Jan 22, 2019

I'm going to go ahead and close this, since it won't work in 0.50 -- we'd really love a new PR though! 😄

@kflynn kflynn closed this Jan 22, 2019
@jtdawso
Copy link
Author

jtdawso commented Jan 22, 2019

@kflynn why won't this work in 0.50? I built it off of 0.50.0

@gertvdijk gertvdijk mentioned this pull request Feb 1, 2019
Closed
@gertvdijk
Copy link
Contributor

gertvdijk commented Feb 1, 2019 •
edited
Loading

@jtdawso I think, what was meant is that the Jinja2 template would only work for Envoy v1 configuration format, not for v2. See now-updated docs in #1175.

@gertvdijk gertvdijk mentioned this pull request Feb 11, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jtdawso @saeid-ir @kflynn @gertvdijk