Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure use_proxy_proto correctly #1061

Merged
merged 1 commit into from
Dec 20, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ambassador/ambassador/envoy/v2/v2listener.py
Original file line number Diff line number Diff line change
Expand Up @@ -331,6 +331,9 @@ def __init__(self, config: 'V2Config', listener: IRListener) -> None:
}
]

if self.use_proxy_proto is not None:
chain['use_proxy_proto'] = self.use_proxy_proto

self.update({
'name': self.name,
'address': {
Expand Down Expand Up @@ -438,7 +441,4 @@ def handle_sni(self, config: 'V2Config') -> None:
if matched:
chain['routes'].append(sni_route['route'])

if self.use_proxy_proto is not None:
chain['use_proxy_proto'] = self.use_proxy_proto

self.filter_chains.append(chain)