Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ambassador doesn't build cleanly after make shell #963

Closed
kflynn opened this issue Nov 8, 2018 · 2 comments
Closed

Ambassador doesn't build cleanly after make shell #963

kflynn opened this issue Nov 8, 2018 · 2 comments
Assignees
@kflynn
Milestone
0.50.0-ea6

Comments

@kflynn
Copy link
Member

kflynn commented Nov 8, 2018

This is causing a lot of onboarding pain.
@kflynn kflynn added this to the 0.50.0-ea6 milestone Nov 8, 2018
@kflynn kflynn self-assigned this Nov 8, 2018
@kflynn
Copy link
Member Author

kflynn commented Nov 8, 2018

Root cause: make clean would delete enough of Ambassador that it couldn't really run, but not enough for the Makefile to realize that it needed to re-install Ambassador. Sigh.

kflynn pushed a commit that referenced this issue Nov 8, 2018
Fixes #963: make sure make clean and make venv interact correctly.
c5d58d0
@kflynn kflynn mentioned this issue Nov 8, 2018
Merged
@kflynn
Copy link
Member Author

kflynn commented Nov 9, 2018

Fixed by #964.

@kflynn kflynn closed this as completed Nov 9, 2018
kflynn pushed a commit that referenced this issue Nov 9, 2018
Merge branch 'release/0.50.0' into flynn/dev/923-tests
f0d4ad8 
* release/0.50.0: (23 commits)
  Split TracingTest into its own file, and add a requirement so we wait for Zipkin to be actually running.
  Fixes #963: make sure make clean and make venv interact correctly.
  word tweak
  add new content on testing in prod
  add section on global tls config
  update ea versions
  Update CHANGELOG for upcoming EA5.
  Default use_remote_address to true
  fix formatting error
  clean up sni docs
  draft SNI documentation
  edits to the SNI doc
  Using `--k8s` with the Ambassador CLI, the `extract_k8s` method must not try to recursively call itself!
  Support V2 header matching.
  rename TLSContext IR file
  make SNI matching more readable
  add SNI user guide
  refactor to apply SNI to all mappings
  Minor documentation clarifications
  SNI, just a foot away
  ...

# Conflicts:
#	ambassador/tests/kat/test_ambassador.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kflynn kflynn

Labels
None yet
Projects
None yet
Milestone
0.50.0-ea6
Development

No branches or pull requests
1 participant
@kflynn