Skip to content

Commit

Permalink
fix: redact secret data in deep links (argoproj#11931)
Browse files Browse the repository at this point in the history
Signed-off-by: Soumya Ghosh Dastidar <[email protected]>

Signed-off-by: Soumya Ghosh Dastidar <[email protected]>
Signed-off-by: emirot <[email protected]>
  • Loading branch information
gdsoumya authored and emirot committed Jan 27, 2023
1 parent 6845fd5 commit 9109737
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions server/application/application.go
Original file line number Diff line number Diff line change
Expand Up @@ -1945,6 +1945,11 @@ func (s *Server) ListResourceLinks(ctx context.Context, req *application.Applica
return nil, fmt.Errorf("failed to read application deep links from configmap: %w", err)
}

obj, err = replaceSecretValues(obj)
if err != nil {
return nil, fmt.Errorf("error replacing secret values: %w", err)
}

finalList, errorList := deeplinks.EvaluateDeepLinksResponse(*obj, deepLinks)
if len(errorList) > 0 {
log.Errorf("errors while evaluating resource deep links, %v", strings.Join(errorList, ", "))
Expand Down

0 comments on commit 9109737

Please sign in to comment.