-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rich text for all widgets #855
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emilk
force-pushed
the
rich-text
branch
2 times, most recently
from
October 30, 2021 09:05
f116fba
to
4059cdf
Compare
emilk
changed the title
Rich text for buttons, Window and CollapsingHeader
Rich text for all widgets
Oct 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces the new types
RichText
andWidgetText
, used for specifying text colors etc forButton, Checkbox, RadioButton, CollapsingHeader
andWindow
.This enables user to have fine control over the labels used in many widgets, for instance to change their fonts, colors, add underlining, or even mix fonts and colors.
WidgetText
can be created from a simpleString
, from aRichText
,LayoutJob
or aGalley
. The last two are the most powerful, but least ergonomic.RichText
is a builder that takes aString
and can then apply color,TextStyle
, strikethrough, underlining, etc.Splitting out text formatting from the widgets makes them more orthogonal, and less code is needed in the widget implementations.
Code breakage
Most old code should work with a helpful deprecation notice.
TODO:
WidgetText
inButton
,Checkbox
,RadioButton
,CollapsingHeader
,SelectableLabel
,Window
titleRichText
: italics, code, underline strikethrough, weak, …WidgetText
inLabel
WidgetText
inHyperlink
WidgetText
inComboBox
WidgetText::Galley
.Label
)CHANGELOG.md
ComboBox
Menu
too complicatedPainter
#[allow(clippy::needless_pass_by_value)]
impl ToString
RichText
.Plotslater PR