Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typos #2866

Merged
merged 5 commits into from
Apr 18, 2023
Merged

Fix typos #2866

merged 5 commits into from
Apr 18, 2023

Conversation

fezjo
Copy link
Contributor

@fezjo fezjo commented Apr 2, 2023

No description provided.

emilk
emilk approved these changes Apr 18, 2023
View reviewed changes
Copy link
Owner

@emilk emilk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Did you use some automated tool for this? Maybe some we could add to the CI?

Before I saw this PR, I started adding a CI step with a another spell checker, but it didn't find everything you found: #2918

@emilk emilk merged commit 33aa4d6 into emilk:master Apr 18, 2023
@fezjo
Copy link
Contributor Author

fezjo commented Apr 18, 2023

Hi, I used cspell (for no particular reason). It had around 300 unique false positives (which is many times more than real positives) when I ran it, so maybe it's not ideal for CI. I could give you the whitelist that I used, but some other tool may be better.

@emilk
Copy link
Owner

emilk commented Apr 18, 2023

Ah, yeah, that's a bit too many :) I'll stick with https://github.com/crate-ci/typos for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilk emilk emilk approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fezjo @emilk