Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wgpu upgraded to 0.15. demo working on linux #2629

Merged
merged 5 commits into from
Jan 27, 2023
Merged

wgpu upgraded to 0.15. demo working on linux #2629

merged 5 commits into from
Jan 27, 2023

Conversation

coderedart
Copy link
Contributor

demo tested on linux.

surface creation is now fallible. that's the only noteworthy change in wgpu.

@coderedart coderedart marked this pull request as ready for review January 26, 2023 06:51
@emilk
Copy link
Owner

emilk commented Jan 26, 2023

Thanks! Let's see if we can resolve some of these duplicated crates that cargo deny catches

@emilk
Copy link
Owner

emilk commented Jan 26, 2023

You may want to merge in master - #2631 should have fixed some of the cargo deny complaints.

The rest should be fixed by cargo update -p accesskit && cargo update -p accesskit_windows

@emilk emilk requested a review from Wumpf January 26, 2023 09:53
Copy link
Collaborator

@Wumpf Wumpf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me! Thank you for updating it so quickly!

let instance = wgpu::Instance::new(configuration.backends);
let instance = wgpu::Instance::new(wgpu::InstanceDescriptor {
backends: configuration.backends,
dx12_shader_compiler: Default::default(), //
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

an attempt at commenting was made, but ultimately failed? :)

@Wumpf
Copy link
Collaborator

Wumpf commented Jan 27, 2023

confirmed web & desktop working with wgpu and passing color tests 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants