-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update wgpu to 0.13 #1670
Update wgpu to 0.13 #1670
Conversation
Is there a guide of different wgsl versions you could link to? It would be good to stick that in the |
Not as far as I'm aware. The latest change was 10 days ago and thing seem to move pretty quickly: gpuweb/gpuweb#2652. |
Running this locally on my mac I get:
|
@emilk These changes are in preparation for the next wgpu release which should bump naga. |
I've updated this to the latest wgpu master. gfx-rs/wgpu#2808 and gfx-rs/wgpu#2808 include some breaking changes so I've modified both the shader and cpu code as a result. |
@emilk this should be mergeable now! |
Utgh, I also need to update the syntax in the wgpu demo app: https://github.com/emilk/egui/blob/master/egui_demo_app/src/apps/custom3d_wgpu_shader.wgsl Unfortunately, I don't know how to test this as the demo app seems pretty hardcoded to use glow at the moment, and I'm not invested enough to change this. |
I've done that via checking it with the |
Not at all! I tested, and it works! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
This should only be merged when a new wgpu release is made
I'm using the git version of naga and currently egui-wgpu panics during shader processing with that because it expects a different syntax for decorations, so I needed to make these changes to get it to work.