Allow scroll into view without specifying an alignment #1247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juancampa
commented
Feb 13, 2022
| @@ -40,7 +42,7 @@ impl Default for FrameState { | |||
| used_by_panels: Rect::NAN, | |||
| tooltip_rect: None, | |||
| scroll_delta: Vec2::ZERO, | |||
| scroll_target: [None; 2], | |||
| scroll_target: [None, None], | |||
There was a problem hiding this comment.
Had to change this because RangeInclusive is not Copy.
emilk
approved these changes
Feb 13, 2022
| /// } | ||
| /// }); | ||
| /// # }); | ||
| /// ``` | ||
| pub fn scroll_to_cursor(&mut self, align: Align) { | ||
| pub fn scroll_to_cursor(&mut self, align: Option<Align>) { |
There was a problem hiding this comment.
This needs documentation for what align=None means
emilk
reviewed
Feb 13, 2022
egui/src/containers/scroll_area.rs
Outdated
| @@ -493,14 +493,17 @@ impl Prepared { | |||
| let clip_rect = content_ui.clip_rect(); | |||
| let visible_range = min..=min + clip_rect.size()[d]; | |||
|
|
|||
| // if the ui is too big to completely fit in the scroll view, align it to the left/top | |||
There was a problem hiding this comment.
Is this the best behavior?
Another alternative is to scroll the minimum amount that makes the scroll view fill with the ui-range. So for instance, if we want to scroll to an image, and that image is very big then we either:
- scroll so that the top of the image is at the top of the scroll view
- scroll so that the bottom of the image is at the bottom of the scroll view (if that is closer)
- don't scroll at all, if all we are currently seeing is the image
There was a problem hiding this comment.
Yeah, I like the simmetry. I fixed it to have that behavior ☝️
emilk
approved these changes
Feb 15, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
response.scroll_to_meworks great. However, in some cases, you only want to bring a UI into view if it's not visible, and don't do anything if it's already visible.Solution
Accept an
Option<Align>instead of justAlign. IfNoneis passed, the minimum scrolling necessary to fully bring the ui into view will be applied.🎥
Peek.2022-02-13.09-49.mp4